Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1123

Unit test FastDatePrinterTimeZonesTest needs a timezone set

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.5
    • lang.time.*
    • None

    • Java 6, timezone is "Europe/Paris" (GMT/UTC +01:00), GNU/Linux.

    • Important

    Description

      In file :

      src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java

      The unit test testCalendarTimezoneRespected set a timezone for the expectedValue but none for the actualValue. Because the actualValue use always the default timezone, then It has to fail.

      Actually, there is no fail because of a bug in FastDatePrinter.format() method (see LANG-916).

      When applying the LANG-916 patch, the unit test flood more than 600 failed:

      cpm > mvn test
Failed tests:
[...]
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM EDT]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM AST]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[12:19PM MDT]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[1:19PM ACT]> but was:<[6:19PM UTC]>
[...]
Tests run: 3544, Failures: 617, Errors: 0, Skipped: 5

      Attachments

        1. LANG-1123-fix-git.patch
          1 kB
          Christian P. MOMON

        Issue Links

          is related to

          Test - A new unit, integration or system test. LANG-1127 Use JUnit rules to set and reset the default Locale and TimeZone

          • Major - Major loss of function.
          • Closed
          is required by

          Bug - A problem which impairs or prevents the functions of the product. LANG-916 CLONE - DateFormatUtils.format does not correctly change Calendar TimeZone in certain situations

          • Major - Major loss of function.
          • Closed

          Activity

            People

              chonton Charles Honton
              cpm Christian P. MOMON
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: