Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0
    • driver-hive, driver-jdbc
    • None

    Attachments

      1. LENS-248.patch
        214 kB
        Rajat Khandelwal
      2. LENS-248.1.patch
        212 kB
        Rajat Khandelwal

      Activity

        amareshwari Amareshwari Sriramadasu added a comment - +1 Review at https://reviews.apache.org/r/30449/

        Patch is not applying - can you update to latest ?

        lens-commit amareshwari.sr$ git apply -p1 ~/Downloads/LENS-248.patch
        error: patch failed: lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:97
        error: lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: patch does not apply
        C02H8

        amareshwari Amareshwari Sriramadasu added a comment - Patch is not applying - can you update to latest ? lens-commit amareshwari.sr$ git apply -p1 ~/Downloads/ LENS-248 .patch error: patch failed: lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:97 error: lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java: patch does not apply C02H8

        updated patch: LENS-248.1.patch

        prongs Rajat Khandelwal added a comment - updated patch: LENS-248 .1.patch

        Committed. Thanks prongs

        amareshwari Amareshwari Sriramadasu added a comment - Committed. Thanks prongs
        hudson Hudson added a comment -

        SUCCESS: Integrated in Lens-Commit #107 (See https://builds.apache.org/job/Lens-Commit/107/)
        LENS-248 : Fix checkstyle issues in lens-driver-hive and lens-driver-jdbc (Rajat Khandelwal via amareshwari) (amareshwari.sr: rev d0baff6b88ede1ab8f9e3d1af53b1b8fa21db7e7)

        • lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java
        • lens-driver-hive/testng.xml
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
        • lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
        • lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java
        • lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java
        • lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java
        • lens-driver-hive/pom.xml
        • lens-driver-jdbc/pom.xml
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
        • lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
        • lens-driver-hive/src/main/resources/hivedriver-default.xml
        • lens-driver-hive/src/test/resources/hivedriver-site.xml
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java
        • lens-driver-jdbc/src/test/resources/hive-site.xml
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
        • lens-driver-hive/testutils/hadoop
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
        • lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ConnectionProvider.java
        • lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveResultSetMetadata.java
        • lens-driver-hive/src/test/resources/hive-site.xml
        • lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
        • lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml
        hudson Hudson added a comment - SUCCESS: Integrated in Lens-Commit #107 (See https://builds.apache.org/job/Lens-Commit/107/ ) LENS-248 : Fix checkstyle issues in lens-driver-hive and lens-driver-jdbc (Rajat Khandelwal via amareshwari) (amareshwari.sr: rev d0baff6b88ede1ab8f9e3d1af53b1b8fa21db7e7) lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java lens-driver-hive/testng.xml lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java lens-driver-hive/pom.xml lens-driver-jdbc/pom.xml lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java lens-driver-hive/src/main/resources/hivedriver-default.xml lens-driver-hive/src/test/resources/hivedriver-site.xml lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java lens-driver-jdbc/src/test/resources/hive-site.xml lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java lens-driver-hive/testutils/hadoop lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ConnectionProvider.java lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveResultSetMetadata.java lens-driver-hive/src/test/resources/hive-site.xml lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml

        People

          prongs Rajat Khandelwal
          amareshwari Amareshwari Sriramadasu
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: