Uploaded image for project: 'Maven Artifact Plugin'
  1. Maven Artifact Plugin
  2. MARTIFACT-64

add diagnose and hints for Git commit timestamp support

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.5.1
    • 3.5.2
    • None

    Description

      some issues with Git commit timestamp support has been reported: need to investigate root cause and provide help

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment - hboutemy merged PR #39: URL: https://github.com/apache/maven-artifact-plugin/pull/39
            githubbot ASF GitHub Bot added a comment -

            michael-o commented on code in PR #39:
            URL: https://github.com/apache/maven-artifact-plugin/pull/39#discussion_r1573860330

            ##########
            src/it/git-multi/pom.xml:
            ##########
            @@ -0,0 +1,80 @@
            +<?xml version="1.0" encoding="UTF-8"?>
            +<!--
            + Licensed to the Apache Software Foundation (ASF) under one
            + or more contributor license agreements. See the NOTICE file
            + distributed with this work for additional information
            + regarding copyright ownership. The ASF licenses this file
            + to you under the Apache License, Version 2.0 (the
            + "License"); you may not use this file except in compliance
            + with the License. You may obtain a copy of the License at
            +
            + http://www.apache.org/licenses/LICENSE-2.0
            +
            + Unless required by applicable law or agreed to in writing,
            + software distributed under the License is distributed on an
            + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
            + KIND, either express or implied. See the License for the
            + specific language governing permissions and limitations
            + under the License.
            +-->
            +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
            + <modelVersion>4.0.0</modelVersion>
            +
            + <groupId>org.apache.maven.plugins.it</groupId>
            + <artifactId>git-multi</artifactId>
            + <version>1.0-SNAPSHOT</version>
            + <packaging>pom</packaging>
            +
            + <description>An IT looking at a multi-module build with outputTimestamp using git commit timestamp.</description>
            +
            + <prerequisites>
            + <maven>3.0.5</maven>
            + </prerequisites>
            +
            + <modules>
            + <module>modB</module>
            + <module>modA</module>
            + </modules>
            +
            + <properties>
            + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
            + <project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>
            + </properties>
            +
            + <build>
            + <plugins>
            + <plugin>
            + <groupId>pl.project13.maven</groupId><!

            githubbot ASF GitHub Bot added a comment - michael-o commented on code in PR #39: URL: https://github.com/apache/maven-artifact-plugin/pull/39#discussion_r1573860330 ########## src/it/git-multi/pom.xml: ########## @@ -0,0 +1,80 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd "> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.maven.plugins.it</groupId> + <artifactId>git-multi</artifactId> + <version>1.0-SNAPSHOT</version> + <packaging>pom</packaging> + + <description>An IT looking at a multi-module build with outputTimestamp using git commit timestamp.</description> + + <prerequisites> + <maven>3.0.5</maven> + </prerequisites> + + <modules> + <module>modB</module> + <module>modA</module> + </modules> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp> + </properties> + + <build> + <plugins> + <plugin> + <groupId>pl.project13.maven</groupId><!
            githubbot ASF GitHub Bot added a comment -

            hboutemy opened a new pull request, #39:
            URL: https://github.com/apache/maven-artifact-plugin/pull/39

            …nd hints on found edge cases

            githubbot ASF GitHub Bot added a comment - hboutemy opened a new pull request, #39: URL: https://github.com/apache/maven-artifact-plugin/pull/39 …nd hints on found edge cases

            People

              hboutemy Herve Boutemy
              hboutemy Herve Boutemy
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: