Uploaded image for project: 'Maven Eclipse Plugin (RETIRED)'
  1. Maven Eclipse Plugin (RETIRED)
  2. MECLIPSE-454

WTP default server configuration only used for Websphere (and not for JBoss and others)

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • 2.5.1
    • None
    • WTP support
    • None
    • Windows XP SP3, JDK 1.5.0_14, Eclipse 3.3.2, Maven 2.0.8
    • Patch

    Description

      The <wtpdefaultserver> configuration setting is currently only used for Websphere servers. But shouldn't setting this to some other server also lead to a <runtime> definition in the Eclipse facets XML file (org.eclipse.wst.common.project.facet.core.xml)?

      For example:
      <wtpdefaultserver>JBoss v4.2</wtpdefaultserver>
      should produce
      <runtime name="JBoss v4.2"/>

      The minimal changes I made to correct this are in EclipseWtpFacetsWriter.writeModuleTypeFacetCore( XMLWriter writer, String packaging ) line 136 ...
      I have simply put the relevant 3 lines out of the Websphere specific if statement.

      if (config.getWorkspaceConfiguration().getDefaultDeployServerName() != null)

      { writer.startElement( "runtime" ); writer.addAttribute( "name", config.getWorkspaceConfiguration().getDefaultDeployServerName() ); writer.endElement(); // runtime }

      if ( this.config.getWorkspaceConfiguration().getWebsphereVersion() != null )

      { writeFacetInstalledElement( writer, FACET_COM_IBM_WEBSPHERE_EXTENDED_EAR, this.config.getWorkspaceConfiguration().getWebsphereVersion() ); // installed writeFacetInstalledElement( writer, FACET_COM_IBM_WEBSPHERE_COEXISTENCE_EAR, this.config.getWorkspaceConfiguration().getWebsphereVersion() ); // installed }

      Best regards,
      Leander

      Attachments

        1. EclipseWtpFacetsWriter.java
          9 kB
          M.-Leander Reimer

        Activity

          People

            Unassigned Unassigned
            lreimer M.-Leander Reimer
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: