Uploaded image for project: 'Maven Enforcer Plugin'
  1. Maven Enforcer Plugin
  2. MENFORCER-182

Missing documentation for new feature MENFORCER-160

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.4
    • Documentation
    • None

    Description

      Currently the documentation for MENFORCER-160 is missing.

      Attachments

        1. MENFORCER-182.patch
          2 kB
          Mirko Friedenhagen

        Issue Links

          Activity

            mfriedenhagen Mirko Friedenhagen added a comment - - edited

            Added a patch for the documentation also available as https://github.com/apache/maven-enforcer/pull/12.

            mfriedenhagen Mirko Friedenhagen added a comment - - edited Added a patch for the documentation also available as https://github.com/apache/maven-enforcer/pull/12 .
            rfscholte Robert Scholte added a comment -

            I don't think this documentation is correct, IIRC level is not a part of alwaysFail

            rfscholte Robert Scholte added a comment - I don't think this documentation is correct, IIRC level is not a part of alwaysFail

            Robert, all standard rules extend Abstract*Rule which implements EnforcerRule2, so level should be there in every rule. The IT from MENFORCER-160 even uses alwaysFail as an example.

            mfriedenhagen Mirko Friedenhagen added a comment - Robert, all standard rules extend Abstract*Rule which implements EnforcerRule2, so level should be there in every rule. The IT from MENFORCER-160 even uses alwaysFail as an example.
            rfscholte Robert Scholte added a comment -

            I suddenly realized the problem: alwaysFail is a rule, not just a Boolean. This rule is there mainly for testing purpose, so a bad example for the usage page. Instead I would use bannedPlugins or bannedDependencies to better understand the usage of level.

            rfscholte Robert Scholte added a comment - I suddenly realized the problem: alwaysFail is a rule, not just a Boolean . This rule is there mainly for testing purpose, so a bad example for the usage page. Instead I would use bannedPlugins or bannedDependencies to better understand the usage of level.

            Add better example using bannedPlugins

            mfriedenhagen Mirko Friedenhagen added a comment - Add better example using bannedPlugins
            khmarbaise Karl Heinz Marbaise added a comment - - edited

            Patch applied into r1561846.
            Thanks to Mirko Friedenhagen.

            khmarbaise Karl Heinz Marbaise added a comment - - edited Patch applied into r1561846 . Thanks to Mirko Friedenhagen.

            People

              Unassigned Unassigned
              khmarbaise Karl Heinz Marbaise
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: