Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-5435

Add default implementations to all Isolator virtual functions

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • None
    • None
    • Mesosphere Sprint 35
    • 1

    Description

      Currently, all of the virtual functions in `mesos::slave::Isolator` are pure virtual (expect status()). For many isolators, however, it doesn't make sense to implement all of these virtual functions. Each isolator has to provide its own default implementation of these functions even if they aren't really relying on them. This adds unnecessary extra code to many isolators that don't need them.

      Moreover, the `MesosIsolatorProcess` has the same problem for each of its virtual functions.

      We should provide defaults for these instead of making each and every isolator implement even in cases when it doesn't make sense.

      Attachments

        Issue Links

          Activity

            People

              klueska Kevin Klues
              klueska Kevin Klues
              Benjamin Mahler Benjamin Mahler
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: