Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-7218

[Regression] o.a.m.model.Build.getSourceDirectory() incorrectly returns absolute dir on 3.8.2

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.8.2
    • 3.8.3
    • Core
    • Maven core jars 3.8.2 (works with 3.8.1 or prior)
      Maven resolver jars 1.7.1
      Mac OS X 10.15.7
      Java 8

    Description

      I have some existing code that started returning an absolute directory from org.apache.maven.model.Build.getSourceDirectory() in 3.8.2 (vs 3.8.1). This is an unexpected breaking change in behavior and contradicts the javadoc which says: "The path given is relative to the project descriptor."

      I am building the model from a pom.xml on disk. I am setting "project.basedir" property to "." and loading the FileModelSource "./pom.xml".

      When I build the model and get the Build.getSourceDirectory() it returned "src/main/java" on 3.8.1 and prior versions.

      In 3.8.2 it now returns "/Users/me/code/mvn-dir-resolution/./src/main/java".

      I created a reproducible runnable case here:

      https://github.com/puredanger/mvn-dir-resolution

       

      I suspect this is related to the change in MNG-7170, but don't know for certain.

      Attachments

        Issue Links

          is caused by

          Improvement - An improvement or enhancement to an existing feature or task. MNG-7170 Allow to associate pomFile/${basedir} with DefaultProjectBuilder.build(ModelSource, ...)

          • Major - Major loss of function.
          • Closed
          is fixed by

          Bug - A problem which impairs or prevents the functions of the product. MNG-7216 Revert MNG-7170

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              michael-o Michael Osipov
              alexmiller Alex Miller
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: