Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-7401

Make MavenSession#getCurrentProject() using a thread local

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.9.0, 4.0.0-alpha-2, 4.0.0
    • None
    • None

    Description

      I noticed that a session is often cloned due to change the current project for a while.

      As this works for everyone passing down the session, consumers of the "upper session" (e.g. a SessionScoped Component) would never see this if they are (indirectly) called and e.g. use Session#getCurrentProject().

      I wonder if MavenSession could simply use a ThreadLocal for the currentProject (that is shared accross all cloned sessions), that way one would always get the correct value.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. MNG-7455 [REGRESSION] IllegalStateException in SessionScope during guice injection in multithreaded build

          • Major - Major loss of function.
          • Closed
          is required by

          Improvement - An improvement or enhancement to an existing feature or task. MNG-7474 SessionScoped beans should be singletons for a given session

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MNG-7347 SessionScoped beans should be singletons for a given session

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #666

          Web Link GitHub Pull Request #743

          Activity

            People

              gnodet Guillaume Nodet
              laeubi Christoph Läubrich
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: