Uploaded image for project: 'Maven Release Plugin'
  1. Maven Release Plugin
  2. MRELEASE-850

mvn release:prepare reformats pom.xml comments

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Auto Closed
    • 2.4.1
    • None
    • None
    • None
    • openSUSE 12.3 (x86-64)

    Description

      We have a Maven project that contains licence headers as XML comments in the pom.xml files. We use a licence checker plugin which checks for the presence of these licence headers.

      It seems the mvn release:prepare command subtly reformats the XML comments. The licence checker runs after this reformatting, and fails since the licence header is no longer an exact match to the reference text. The problem occurs with the following comment lines:

      You should have received a copy of the GNU General Public License
      along with this program. If not, see <http://www.gnu.org/licenses/>.

      Maven inserts some extra whitespace:

      You should have received a copy of the GNU General Public License
      along with this program. If not, see <http://www.gnu.org/licenses />.

      I suspect this is a bug in Maven (or whatever XML parser it relies on). Maven should not reformat XML comments (and especially not in a URL where whitespace is significant).

      Attachments

        1. pom.xml
          5 kB
          Tristan Miller

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. MRELEASE-601 The Maven 2 release plugin modifies CDATA elements in pom.xml files.

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MRELEASE-266 Content outside root elements in pom are not transfered to the release poms

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MRELEASE-607 release:prepare messes up line wrapping in pom.xml

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MRELEASE-676 prepare goal corrupts pom.xml file by removing some line breaks in CDATA

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MRELEASE-1111 release:prepare reformat empty tags

          • Major - Major loss of function.
          • Open

          Activity

            People

              Unassigned Unassigned
              psychonaut Tristan Miller
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: