Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-588

Incomplete system properties in SessionBuilderSupplier

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 2.0.0
    • None
    • Resolver
    • None

    Description

      The SessionBuilderSupplier provided for Maven3 sets the java System.properties as systemProperties of the Session to be build.

      https://github.com/apache/maven-resolver/blob/d13019ce5fa38c0951ca0fb0c62a3f5f1254cffc/maven-resolver-supplier-mvn3/src/main/java/org/eclipse/aether/supplier/SessionBuilderSupplier.java#L72

      But it does not add environment variables with their key prefixed with env. like it is for example done in Maven or MIMA:

      https://github.com/maveniverse/mima/blob/e851dee08706024929f1004e18e3dbd7b3522b36/runtime/standalone-shared/src/main/java/eu/maveniverse/maven/mima/runtime/shared/StandaloneRuntimeSupport.java#L519-L530

       

      From looking at the code of the SessionBuilderSupplier for Maven 4, which relys heavily on {{org.apache.maven.repository.internal.MavenSessionBuilderSupplier }}system properties are not set at all.

      My suggestion is to extend the Maven3 SessionBuilderSupplier in Maven-Resolver and in maven4 MavenSessionBuilderSupplier to have system-properties and environment variables fully set by default.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              HannesWellmann Hannes Wellmann
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: