Uploaded image for project: 'Maven Shared Components'
  1. Maven Shared Components
  2. MSHARED-83

populateModulesMenuItemsFromReactorProjects logic is incorrect, a module does not have to be a child

    XMLWordPrintableJSON

Details

    • Patch

    Description

      Some of this is my fauilt as the code in question came from some of the patch wsork i did on 2.0-beta-6.

      Basically populateModulesMenuItemsFromReactorProjects uses the following to determine if a project in the reactor is a module of the current project:

                      if ( reactorProject != null && reactorProject.getParent() != null
                    && project.getArtifactId().equals( reactorProject.getParent().getArtifactId() ) )

      This is invalid. A module != child

      This needs to be changed to a check that's based upon the project's location, for that's all we've got when it comes to determining the backref relationship of a module to its aggregator (the enclosing project that refered to the module via a <module> element.

      Patch will follow

      Attachments

        Issue Links

          is depended upon by

          Bug - A problem which impairs or prevents the functions of the product. MSITE-129 modules list empty if modules don't use this project as parent in reactor build

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MSITE-163 The modules menu is not inherited if the parent project has no modules of its own

          • Major - Major loss of function.
          • Closed
          supercedes

          Bug - A problem which impairs or prevents the functions of the product. MSITE-136 when inheriting site.xml the <menu ref='parent'> expands to a menu with links for *all* ancestors and not just the immediate parent

          • Major - Major loss of function.
          • Closed

          Activity

            People

              dennisl@apache.org Dennis Lundberg
              skaze skaze
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: