Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-3151

[perf] minimize ExternalContext.getInitParameter invocations in myfaces API

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.0-SNAPSHOT
    • 2.1.0
    • General
    • None
    • myfaces core trunk

    Description

      init-param from webapp context cannot change - it is sufficient read it once in constructor (ApplicationImpl for example)

      New problem (new in 2.1) is "great" javax.faces.HONOR_CURRENT_COMPONENT_ATTRIBUTES param for pushComponentToEL and popComponentFromEL - at least we can cache it in component (because push and pop are called more then ones during one lifecycle) and maybe cache it's value also in org.apache.myfaces.context.servlet.ServletExternalContextImplBase.getInitParameter(String)

      I have about ~ 90 000 invocations of getInitPaparameter in my test case in one request/response and that is not cheap.

      Attachments

        1. MYFACES-3151-ApplicationImpl.patch
          3 kB
          Martin Kočí
        2. MYFACES-3151-UIComponent.patch
          5 kB
          Martin Kočí
        3. MYFACES-3151-UINamingContainer.patch
          3 kB
          Martin Kočí

        Activity

          People

            markoc50 Martin Kočí
            markoc50 Martin Kočí
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: