Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-3470

[perf] review markCreated, markForDeletion, finalizeForDeletion algorithm

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Not A Problem
    • None
    • None
    • None
    • None

    Description

      Whe using PPS, ComponentTagHandlerDelegate.apply:

      1) generates a unique id: String id = ctx.generateUniqueId(_delegate.getTagId());
      2) stores it in component.attributes under key MARK_CREATED c.getAttributes().put(ComponentSupport.MARK_CREATED, id)

      both steps creates new instances (StringBuilder, HashMap.Entry).

      But is seems, that this MARK_CREATED is used only in case of RefreshingTransientBuild = true and it is probably not necessary create and store that id for every component.

      Attachments

        Issue Links

          Activity

            People

              lu4242 Leonardo Uribe
              markoc50 Martin Kočí
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: