Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4239

[perf] Additional performance improvements

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2.12, 2.3.1
    • 2.2.13, 2.3.2
    • JSR-372
    • None

    Description

      Some performance improvements in :

      1) ApplicationImpl.java

      2) ServletExternalContextImpl.java

      3) HtmlResponseWriterImpl.java

      4) HTMLEncoder.java, we also discussed on the mailing list changing encodeURIAtributte to encodeUriAttribute to fix the typo in the method name so I'll do that here as well.

      5) ResourceValidationUtils.java

      The following changes were made:

      • Skip calling ConcurrentHashMap.containsKey since we will call get
        afterward if containsKey == true.
      • Stop using Boolean for variables that don't have a null meaning. If
        null == false, then just use boolean with a default of false.
      • Don't call String.length() constantly for String variables that aren't re-assigned.
      • Change conditional order to avoid calling validateResourceName unless the other conditions are true

      Attachments

        Activity

          People

            paul.nicolucci Paul Nicolucci
            paul.nicolucci Paul Nicolucci
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: