Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4266

Ajax update fails due to invalid characters in response XML (DoS)

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3.2
    • 2.2.13, 2.3.3, 2.3-next-M1
    • None
    • None
    • jetty 9.4.14.v20181114
      JDK 10

    Description

      I noticed that the <f:ajax /> update fails when the updated form contains unicode characters, which are not allowed in the XML 1.0 spec.

      Expected Behaviour

      If the update response contains characters that are not allowed in XML, they should be filtered by MyFaces before writing the response.

      Actual Behaviour

      Some illegal XML characters are not filtered and therefore the browser fails to parse the response.

      Steps to reproduce

      I created a small github project to reproduce this behaviour: https://github.com/cnsgithub/mojarra-ajax/tree/myfaces (branch myfaces)
      To reproduce:

      The issue also occurs with user supplied inputs:

      This issue should be addressed with high priority since it is security related (might be exploited for Denial of Service).

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              cnsgithub cnsgithub
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: