Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Invalid
-
4.0.0-RC2
-
None
-
None
-
None
Description
Rather than generating the mappings ourselves, we should just rely on HttpServletMapping: https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/http/httpservletmapping
I tried updating it myself, but ran into issues with the unit test since we don't have an underlying servlet in these tests (but a Mock one instead). This caused the returned HttpServletMapping to be nul due to the super call belowl, and hundreds of tests failed.
@Override public HttpServletMapping getHttpServletMapping() { return HttpServletRequest.super.getHttpServletMapping(); }
Initial test branch: https://github.com/volosied/myfaces/commits/fix-mappings
By updating here, we would also follow Mojarra: https://github.com/eclipse-ee4j/mojarra/pull/4956