Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4536

PartialResponseWriter: Do no wrap the writer

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Invalid
    • 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
    • None
    • General
    • None

    Description

      Per BalusC:

      Since JSF 2.3 the default constructor of FacesWrapper subclasses has been deprecated in order to force implementors to instead use the constructor taking the wrapped instance (and to raise their awareness), so that logically the inherited getWrapped() method will be used throughout the implementation instead of the local wrapped variable. This will ensure that the correct implementation is returned and correct behavior is performed might the FacesWrapper implementation itself being wrapped by yet another FacesWrapper implementation further down the chain. Because, when the FacesWrapper implementation incorrectly/accidentally uses the local wrapped variable instead of the getWrapped() method, then that other FacesWrapper implementation will basically be completely ignored, hereby breaking the decorator pattern.

       

      PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518

      Attachments

        1. csp-results.zip
          7 kB
          Melloware
        2. image-2023-10-02-20-33-05-162.png
          28 kB
          Werner Punz
        3. mojarra-csp-new.txt
          15 kB
          Melloware

        Issue Links

          Activity

            People

              werpu Werner Punz
              melloware Melloware
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: