Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4552

TCK spec/flows/basicswitch default flow outcome failure caused by incorrect set call

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3-next-M7, 4.0.0-RC4
    • 4.0.0-RC5
    • None
    • None

    Description

      Switch case test failed for flow b / switch c in the test.

      Test: https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L61

      https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L95

      <switch id="switchC">
      <case>
      <if>#{flow_b_Bean.switchC_Case01}</if>
      <from-outcome>page01</from-outcome>
      </case>
      <case>
      <if>#{flow_b_Bean.switchC_Case02}</if>
      <from-outcome>page02</from-outcome>
      </case>
      <case>
      <if>#{flow_b_Bean.switchC_Case03}</if>
      <from-outcome>page03</from-outcome>
      </case>
      <default-outcome>#{flow_b_Bean.defaultOutcome}</default-outcome>
      </switch>

      The switch conditions were false so the code should have used the default outcome.

      https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L838-L849

      However, the outcome was null because it was improperly set during the FacesConfigUnmarshallerImpl.java code.

      Attachments

        1. faces_flows_basicswitch_web.war
          15 kB
          Volodymyr Siedlecki

        Issue Links

          Activity

            People

              volosied Volodymyr Siedlecki
              volosied Volodymyr Siedlecki
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: