Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-10719

oak-lucene uses Lucene version that can throw a StackOverflowException

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.64.0, 1.22.21
    • lucene
    • None

    Description

      See <https://github.com/apache/lucene/issues/11537>.

      Analysis so far:

      • oak-lucene uses lucene-core (4.7.2) (see OAK-10716); that version has reached EOL a long time ago
      • the lucene version can in some cases throw a StackOverflowException, see OAK-10713
      • oak-lucene embeds and exports lucene-core
      • update to version >= 4.8 non-trivial due to backwards compat breakage

      Work in <https://github.com/reschke/jackrabbit-oak-lucene/tree/lucene-poc>:

      • inlined lucene-core as of git tag "releases/lucene-solr/4.7.2" into oak-lucene
      • fixed two JDK11 compile issues (potentially uninitialized vars in finally block)
      • backported fix from https://github.com/apache/lucene/issues/11537
      • enable test added in OAK-10713
      • ran Oak integration tests

      Open questions:

      • Lucene 4.7.2 builds with ant/ivy - does it make sense to try to replicate that
      • should we ask Lucene team for a public release (might be hard sell)
      • alternatively, as tried here, inline source code into oak-lucene (maybe add explainers to all source files)
      • do we need to adopt the lucene test suite as well?
      • lucene-core dependencies in other Oak modules to be checked (seems mostly for tests, or for run modules)

      Attachments

        Issue Links

          There are no Sub-Tasks for this issue.

          Activity

            People

              reschke Julian Reschke
              reschke Julian Reschke
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: