Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4686

DocumentNodeStoreTest#compareOnBranch fails for update.limit=10000

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.5.9, 1.6.0
    • None
    • None

    Description

      I think this started with recent improvements to not drop to Persisted if update limit isn't hit. Following change to the test makes it pass:

      diff --git a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
      index 35ee306..c52e32d 100644
      --- a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
      +++ b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
      @@ -2566,7 +2566,10 @@ public class DocumentNodeStoreTest {
               builder.child("parent").child("node-x").child("child").child("x");
               b.setRoot(builder.getNodeState());
               // branch state is now InMemory
      -        builder.child("b");
      +//        builder.child("b");
      +        for (int i = 0; i < DocumentRootBuilder.UPDATE_LIMIT; i++) {
      +            builder.child("b" + i);
      +        }
               b.setRoot(builder.getNodeState());
               // branch state is now Persisted
               builder.child("c");
      

      Thanks chetanm for spotting this. mreutegg, is it ok to update the test?

      Attachments

        Issue Links

          Activity

            People

              catholicon Vikas Saurabh
              catholicon Vikas Saurabh
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: