Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-11414 Improve the BI component
  3. OFBIZ-11430

getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Abandoned
    • Trunk, Upcoming Branch
    • None
    • bi

    Description

      Currently the 'getDimensionIdFromNaturalKey' function in DimensionServices.java returns the DimensionId when found with following code excerpt

      if (UtilValidate.isNotEmpty(lastDimensionValue)) {
                  resultMap.put("dimensionId", lastDimensionValue.getString("dimensionId"));
              }
      return resultMap;
      

      And when not found it returns an empty result, leaving the using function upstream to set the '_NF' value.

      The 'getDimensionIdFromNaturalKey' function should return the 'NF' value when no matching dimensionId is found.

      This would simplify the upstream code.

      Attachments

        Activity

          People

            mbrohl Michael Brohl
            pierresmits Pierre Smits
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: