Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-187

Simplify BitFieldReader to only support single bits

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4.0
    • 1.5.0
    • Java, Reader
    • None

    Description

        /** The number of bits in one item. Non-test code always uses 1. */
  private final int bitSize;

      The bitField reader was originally supposed to be extensible as an Integer reader with packing - but HIVE-7219 introduced parallel unpack routines which were better.

      This makes BitFieldReader::next() the core hotspot for integer sequences.

      Attachments

        1. perf-top-bitReader.png
          22 kB
          Gopal Vijayaraghavan
        2. perf-top-bitReader-asm.png
          25 kB
          Gopal Vijayaraghavan
        3. perf_with_fix.png
          230 kB
          Rajesh Balamohan
        4. perf_asm.png
          189 kB
          Rajesh Balamohan
        5. perf_latest_patch.png
          144 kB
          Rajesh Balamohan

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. ORC-367 Boolean columns are read incorrectly when using seek.

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #186

          Activity

            People

              rajesh.balamohan Rajesh Balamohan
              gopalv Gopal Vijayaraghavan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: