Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-351

Decimal64ColumnWriter buffer has not enough size to encode decimals with precision > 16

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 1.5.0
    • C++
    • None

    Attachments

      Issue Links

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user rip-nsk opened a pull request:

          https://github.com/apache/orc/pull/254

          ORC-351: [C++] Increase buffer in Decimal*ColumnWriter to required size

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rip-nsk/orc ORC-351

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/orc/pull/254.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #254


          commit ea25c4a7cc0a445bbeae35fb4da4a3cb11ee5e0f
          Author: rip-nsk <rip.nsk@...>
          Date: 2018-04-21T19:45:47Z

          Increase buffer in Decimal*ColumnWriter to required size


          githubbot ASF GitHub Bot added a comment - GitHub user rip-nsk opened a pull request: https://github.com/apache/orc/pull/254 ORC-351 : [C++] Increase buffer in Decimal*ColumnWriter to required size You can merge this pull request into a Git repository by running: $ git pull https://github.com/rip-nsk/orc ORC-351 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/orc/pull/254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #254 commit ea25c4a7cc0a445bbeae35fb4da4a3cb11ee5e0f Author: rip-nsk <rip.nsk@...> Date: 2018-04-21T19:45:47Z Increase buffer in Decimal*ColumnWriter to required size
          githubbot ASF GitHub Bot added a comment -

          Github user majetideepak commented on the issue:

          https://github.com/apache/orc/pull/254

          Can you add a test as well? Thanks.

          githubbot ASF GitHub Bot added a comment - Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/254 Can you add a test as well? Thanks.
          githubbot ASF GitHub Bot added a comment -

          Github user wgtmac commented on a diff in the pull request:

          https://github.com/apache/orc/pull/254#discussion_r183225354

          — Diff: c++/src/ColumnWriter.cc —
          @@ -1453,7 +1453,7 @@ namespace orc {
          uint64_t numValues) override;

          private:

          • char buffer[16];
            + char buffer[20];
              • End diff –

          19 should be sufficient, right?

          githubbot ASF GitHub Bot added a comment - Github user wgtmac commented on a diff in the pull request: https://github.com/apache/orc/pull/254#discussion_r183225354 — Diff: c++/src/ColumnWriter.cc — @@ -1453,7 +1453,7 @@ namespace orc { uint64_t numValues) override; private: char buffer [16] ; + char buffer [20] ; End diff – 19 should be sufficient, right?
          githubbot ASF GitHub Bot added a comment -

          Github user rip-nsk commented on a diff in the pull request:

          https://github.com/apache/orc/pull/254#discussion_r183225681

          — Diff: c++/src/ColumnWriter.cc —
          @@ -1453,7 +1453,7 @@ namespace orc {
          uint64_t numValues) override;

          private:

          • char buffer[16];
            + char buffer[20];
              • End diff –

          Yes, both buffers are "aligned" to 2 bytes

          githubbot ASF GitHub Bot added a comment - Github user rip-nsk commented on a diff in the pull request: https://github.com/apache/orc/pull/254#discussion_r183225681 — Diff: c++/src/ColumnWriter.cc — @@ -1453,7 +1453,7 @@ namespace orc { uint64_t numValues) override; private: char buffer [16] ; + char buffer [20] ; End diff – Yes, both buffers are "aligned" to 2 bytes
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/orc/pull/254

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/254
          omalley Owen O'Malley added a comment -

          I just committed this. Thanks, rip.nsk!

          omalley Owen O'Malley added a comment - I just committed this. Thanks, rip.nsk!
          omalley Owen O'Malley added a comment -

          Released as ORC 1.5.0.

          omalley Owen O'Malley added a comment - Released as ORC 1.5.0.

          People

            rip.nsk@gmail.com Renat Valiullin
            rip.nsk@gmail.com Renat Valiullin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: