Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-683

PPD: Make Floating point NaN check more strict

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.6.4, 1.6.5, 1.7.0
    • 1.6.6, 1.7.0
    • None
    • None

    Description

      ORC-629 added an extra check (part of  RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.

      However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.
      https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java#L568

      Attachments

        Issue Links

          Activity

            People

              pgaref Panagiotis Garefalakis
              pgaref Panagiotis Garefalakis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: