Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4338 Move to HBase-2.0
  3. PHOENIX-4376

Fix all compilation error for package org.apache.phoenix.schema.stats and org.apache.phoenix.coprocessor

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.0.0-alpha
    • None

    Description

      – It includes updating the coprocessor hook with right definition.
      – Changing HRegionInfo to RegionInfo.
      – Cell related changes.
      Like

      -        byte[] viewConstant = viewConstantKv == null ? null : viewConstantKv.getValue();
      +        byte[] viewConstant = viewConstantKv == null ? null : CellUtil.cloneValue(viewConstantKv);
      -                    Cell viewStatementCell = new KeyValue(cell.getRow(), cell.getFamily(), VIEW_STATEMENT_BYTES,
      +                    Cell viewStatementCell = new KeyValue(CellUtil.cloneRow(cell), CellUtil.cloneFamily(cell), VIEW_STATEMENT_BYTES,
      

      – Update scan

      -            scan.setStartRow(HConstants.EMPTY_START_ROW);
      -            scan.setStopRow(HConstants.EMPTY_END_ROW);
      +            scan.withStartRow(HConstants.EMPTY_START_ROW);
      +            scan.withStopRow(HConstants.EMPTY_END_ROW);
      

      – preSplit hook needs to be removed and fixed in PHOENIX-4352.
      – Requires a separate fix of PHOENIX-4277 and PHOENIX-3081 for HBase 2.0

      Attachments

        1. PHOENIX-4376.patch
          29 kB
          Ankit Singhal

        Issue Links

          Activity

            ankit@apache.org Ankit Singhal added a comment -

            elserj, for review

            ankit@apache.org Ankit Singhal added a comment - elserj , for review
            elserj Josh Elser added a comment -
            +      if (scan.isRaw() || ScanInfoUtil.isKeepDeletedCells(((HStore)store).getScanInfo()) || scan.getTimeRange().getMax() == HConstants.LATEST_TIMESTAMP || TransactionUtil.isTransactionalTimestamp(scan.getTimeRange().getMax())) {
            

            We should get rid of the ((HStore) store).getScanInfo(). Can you switch ScanInfoUtil.isKeepDeleteCells to take a Store and have the method use store.getColumnFamilyDescriptor().getKeepDeletedCells() instead?

            +1 otherwise.

            elserj Josh Elser added a comment - + if (scan.isRaw() || ScanInfoUtil.isKeepDeletedCells(((HStore)store).getScanInfo()) || scan.getTimeRange().getMax() == HConstants.LATEST_TIMESTAMP || TransactionUtil.isTransactionalTimestamp(scan.getTimeRange().getMax())) { We should get rid of the ((HStore) store).getScanInfo() . Can you switch ScanInfoUtil.isKeepDeleteCells to take a Store and have the method use store.getColumnFamilyDescriptor().getKeepDeletedCells() instead? +1 otherwise.
            ankit@apache.org Ankit Singhal added a comment -

            We should get rid of the ((HStore) store).getScanInfo(). Can you switch ScanInfoUtil.isKeepDeleteCells to take a Store and have the method use store.getColumnFamilyDescriptor().getKeepDeletedCells() instead?

            Actually, this whole code needs to be removed and some alternative needs to think for PHOENIX-4378.

            Committed to 5.x-HBase-2.0 branch.

            ankit@apache.org Ankit Singhal added a comment - We should get rid of the ((HStore) store).getScanInfo(). Can you switch ScanInfoUtil.isKeepDeleteCells to take a Store and have the method use store.getColumnFamilyDescriptor().getKeepDeletedCells() instead? Actually, this whole code needs to be removed and some alternative needs to think for PHOENIX-4378 . Committed to 5.x-HBase-2.0 branch.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1930 (See https://builds.apache.org/job/PreCommit-PHOENIX-Build/1930/)
            PHOENIX-4376 Fix all compilation error for package (ankitsinghal59: rev e1238aa3cb8cdf962b70ca8f1ae197285c558891)

            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java
            • (delete) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/ScanInfoUtil.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/DefaultStatisticsCollector.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectionRunTracker.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsUtil.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
              PHOENIX-4376 Some more fixes for Coprocessor (ankitsinghal59: rev 2a9a9f0908660ba67cb05637269acbdd293bda53)
            • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/FlappingLocalIndexIT.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuildManager.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixMRJobUtil.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
            • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinCacheIT.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionCoprocessorEnvironment.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SequenceRegionObserver.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/table/CoprocessorHTableFactory.java
            • (edit) phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
            • (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/TestWALRecoveryCaching.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1930 (See https://builds.apache.org/job/PreCommit-PHOENIX-Build/1930/ ) PHOENIX-4376 Fix all compilation error for package (ankitsinghal59: rev e1238aa3cb8cdf962b70ca8f1ae197285c558891) (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java (delete) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/ScanInfoUtil.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/DefaultStatisticsCollector.java (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectionRunTracker.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsUtil.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java PHOENIX-4376 Some more fixes for Coprocessor (ankitsinghal59: rev 2a9a9f0908660ba67cb05637269acbdd293bda53) (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/FlappingLocalIndexIT.java (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuildManager.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java (edit) phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixMRJobUtil.java (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinCacheIT.java (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionCoprocessorEnvironment.java (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SequenceRegionObserver.java (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/table/CoprocessorHTableFactory.java (edit) phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/TestWALRecoveryCaching.java

            People

              ankit@apache.org Ankit Singhal
              ankit@apache.org Ankit Singhal
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: