Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4781

Phoenix client project's jar naming convention causes maven-deploy-plugin to fail

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Resolved
    • 5.0.0, 4.14.1
    • 4.15.0, 5.1.0, 4.14.2
    • None
    • None

    Description

      `maven-deploy-plugin` is used for deploying built artifacts to repository provided by `distributionManagement` tag. The name of files that need to be uploaded are either derived from pom file of the project or it generates an temporary one on its own.

      For `phoenix-client` project, we essentially create a shaded uber jar that contains all dependencies and provide the project pom file for the plugin to work. `maven-jar-plugin` is disabled for the project, hence the shade plugin essentially packages the jar. The final name of the shaded jar is defined as `phoenix-${project.version}-client`, which is different from how the standard maven convention based on pom file (artifact and group id) is `phoenix-client-${project.version}`

      This causes `maven-deploy-plugin` to fail since it is unable to find any artifacts to be published.

      `maven-install-plugin` works correctly and hence it installs correct jar in local repo.

      The same is effective for `phoenix-pig` project as well. However we require the require jar for that project in the repo. I am not even sure why we create shaded jar for that project.

      I will put up a 3 liner patch for the same.

      Any thoughts? sergey.soldatov elserj

      Files before change (first col is size):

      103487701 Jun 13 22:47 phoenix-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT-client.jar

      Files after change (first col is size):

      3640 Jun 13 21:23 original-phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar
      103487702 Jun 13 21:24 phoenix-client-4.14.0-HBase-1.3-sfdc-1.0.14-SNAPSHOT.jar

      Attachments

        1. PHOENIX-4781.4.x-HBase-1.4.v5.patch
          2 kB
          Vincent Poon
        2. PHOENIX-4781.4.x-HBase-1.4.v4.patch
          2 kB
          Vincent Poon
        3. PHOENIX-4781.addendum.patch
          1 kB
          Vincent Poon
        4. PHOENIX-4781.4.x-HBase-1.4.v3.patch
          3 kB
          Vincent Poon
        5. PHOENIX-4781.002.patch
          2 kB
          Karan Mehta
        6. PHOENIX-4781.001.patch
          2 kB
          Karan Mehta

        Issue Links

          Activity

            People

              karanmehta93 Karan Mehta
              karanmehta93 Karan Mehta
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: