Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4977

Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Resolved
    • 4.14.0
    • 4.14.1, 5.1.0
    • None
    • None

    Description

      Currently PhoenixIndexFailurePolicy, which is the default policy, delegates to KillServerOnFailurePolicy. This is hardcoded in the constructor. Apparently this was added for a specific use case, BLOCK_DATA_TABLE_WRITES_ON_WRITE_FAILURE, and the policy itself derives from the days where forcing a RS kill was in effect the way to 'rebuild' the index via WAL replay.
      There are still cases where it's applicable, such as when Syscat itself cannot be updated in order to e.g. disable an index. However, killing the RS may be too aggressive for some, who might prefer a temporarily out of sync index to a potentially cascading wave of aborts.
      We should add a config option to control this.

      Attachments

        1. PHOENIX-4977.v1.4.x-HBase-1.4.patch
          5 kB
          Vincent Poon
        2. PHOENIX-4977.v2.4.x-HBase-1.4.patch
          4 kB
          Vincent Poon

        Activity

          People

            vincentpoon Vincent Poon
            vincentpoon Vincent Poon
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: