Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5980

MUTATION_BATCH_FAILED_SIZE metric is incorrectly updated for failing delete mutations

    XMLWordPrintableJSON

Details

    Description

      In the conn.commit() path, we get the number of mutations that failed to be committed in the catch block of MutationState.sendMutations() (see here).

      In case of delete mutations, the uncommittedStatementIndexes.length always resolves to 1 and we always update the metric value by 1 in this case, even though the actual mutation list corresponds to multiple DELETE mutations which failed. In case of upserts, using unCommittedStatementIndexes.length is fine since each upsert query corresponds to 1 Put. We should fix the logic for deletes/mixed delete + upsert mutation batch failures.

      This wrong value is propagated to global client metrics as well as MutationMetricQueue metrics.

      Attachments

        Activity

          People

            divneet18 Divneet Kaur
            ckulkarni Chinmay Kulkarni
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: