Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6010

Create phoenix-thirdparty, and consume guava through it

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.1.0, 4.16.0
    • 5.1.0
    • core, omid, tephra
    • None

    Description

      We have long-standing and well-documented problems with Guava, just like the rest of the Hadoop components.

      Adopt the solution used by HBase:

      • create phoenix-thirdparty repo
      • create a pre-shaded phoenix-shaded-guava artifact in it
      • Use the pre-shaded Guava in every phoenix component

      The advantages are well-known, but to name a few:

      • Phoenix will work with Hadoop 3.1.3+
      • One less CVE in our direct dependencies
      • No more conflict with our consumer's Guava versions

      Attachments

        1. PHOENIX-6010.master.10.patch
          526 kB
          Istvan Toth
        2. PHOENIX-6010.master.v1.patch
          452 kB
          Istvan Toth
        3. PHOENIX-6010.master.v2.patch
          456 kB
          Istvan Toth
        4. PHOENIX-6010.master.v3.patch
          457 kB
          Istvan Toth
        5. PHOENIX-6010.master.v4.patch
          456 kB
          Istvan Toth
        6. PHOENIX-6010.master.v5.patch
          456 kB
          Istvan Toth
        7. PHOENIX-6010.master.v6.patch
          457 kB
          Istvan Toth
        8. PHOENIX-6010.master.v7.patch
          457 kB
          Istvan Toth
        9. PHOENIX-6010.master.v8.patch
          524 kB
          Istvan Toth
        10. PHOENIX-6010.master.v9.patch
          526 kB
          Istvan Toth

        Issue Links

          fixes

          Task - A task that needs to be done. PHOENIX-5331 Get onto newer guava

          • Major - Major loss of function.
          • Closed
          incorporates

          Improvement - An improvement or enhancement to an existing feature or task. PHOENIX-6234 Replace Guava with phoenix-thirdparty version in 4.x

          • Major - Major loss of function.
          • Resolved
          is a parent of

          Improvement - An improvement or enhancement to an existing feature or task. OMID-156 refactor Omid to use phoenix-shaded-guava

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. TEPHRA-308 create artifact with shaded Guava and Twill in Tephra

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PHOENIX-4262 Create shaded packages to shade all uses of Guava

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR

          Activity

            People

              stoty Istvan Toth
              stoty Istvan Toth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2.5h
                  2.5h