[PIG-2132] Piggybank: MIN and MAX functions should ignore nulls - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 0.10.1
Fix Version/s: 0.13.0
Component/s: tools
Labels:
- newbie
- piggybank

Release Note:

Hide
All I did was go through all of the Max and Min functions in Piggybank and add
if (first==null)
    return second;
if (second==null)
    return first;

Following conversation on the message board, the desired outputs are:
null,null -> null
1,null -> 1
null,1 -> 1
1,1 -> 1

This change gives that.

Show
All I did was go through all of the Max and Min functions in Piggybank and add if (first==null)     return second; if (second==null)     return first; Following conversation on the message board, the desired outputs are: null,null -> null 1,null -> 1 null,1 -> 1 1,1 -> 1 This change gives that.
Tags:
piggybank

Description

org.apache.pig.piggybank.evaluation.math.MAX and org.apache.pig.piggybank.evaluation.math.MIN throws a NullPointerException on a null input, when it should just ignore it.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

PIG-2132_2.patch
27/Nov/13 19:47
7 kB
Cheolsoo Park
PIG-2132_1.patch
25/Nov/13 09:16
51 kB
Rekha Joshi
JcoMaxMinPatch_wtests.patch
18/Jun/11 15:49
23 kB
Jonathan Coveney
JcoMaxMinPatch.patch
17/Jun/11 17:51
7 kB
Jonathan Coveney

Activity

People

Assignee:: Rekha Joshi

Reporter:: Jonathan Coveney

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 17/Jun/11 17:07

Updated:: 07/Jul/14 18:08

Resolved:: 27/Nov/13 21:21

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified