Uploaded image for project: 'Polygene'
  1. Polygene
  2. POLYGENE-222

Remove Indexing-SQL from 3.0

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • None
    • 3.0.0
    • None

    Description

      In POLYGENE-180 we noticed that some Indexing SQL tests were failing. But the situation is not that simple.

      I bisected to find the offending commits, here are my findings:

      The last good commit is 4dabe5781cd73463526951b70b097c2f0b45b320.

      d845ea705b05b3d8182086ba82979fa8332bde78 is the first bad commit with these 7 tests failing:

      PostgreSQLEntityFinderTest. script03
PostgreSQLEntityFinderTest. script18
PostgreSQLEntityFinderTest. script19
PostgreSQLQueryTest. script03
PostgreSQLQueryTest. script17
PostgreSQLQueryTest. script18
PostgreSQLQueryTest. script19

      then 5d2a62bef95828222c17c1c2b413ac43d8d2b71b made ALL tests fail

      then a5be013f39cba9642114e01486cdff0c355569f2 fixed some tests but the following 19 still fail:

      PostgreSQLComplexQueryTest. script01
PostgreSQLComplexQueryTest. script02
PostgreSQLComplexQueryTest. script03
PostgreSQLComplexQueryTest. script05
PostgreSQLComplexQueryTest. script06
PostgreSQLComplexQueryTest. script07
PostgreSQLComplexQueryTest. script08
PostgreSQLComplexQueryTest. script09
PostgreSQLComplexQueryTest. script10
PostgreSQLComplexQueryTest. script11
PostgreSQLEntityFinderTest. script03
PostgreSQLEntityFinderTest. script18
PostgreSQLEntityFinderTest. script19
PostgreSQLQueryTest. script03
PostgreSQLQueryTest. script17
PostgreSQLQueryTest. script18
PostgreSQLQueryTest. script19
PostgreSQLQueryTest. script29
PostgreSQLQueryTest. script32

      then dedb068e4b56fce8d6c21f5938396eb84da63f7c made ALL tests fail again

      then e5c57f95e199f8a79763debb2e101028f8e8f896 fixed some tests but the following 19 still fail, same as above:

      PostgreSQLComplexQueryTest. script01
PostgreSQLComplexQueryTest. script02
PostgreSQLComplexQueryTest. script03
PostgreSQLComplexQueryTest. script05
PostgreSQLComplexQueryTest. script06
PostgreSQLComplexQueryTest. script07
PostgreSQLComplexQueryTest. script08
PostgreSQLComplexQueryTest. script09
PostgreSQLComplexQueryTest. script10
PostgreSQLComplexQueryTest. script11
PostgreSQLEntityFinderTest. script03
PostgreSQLEntityFinderTest. script18
PostgreSQLEntityFinderTest. script19
PostgreSQLQueryTest. script03
PostgreSQLQueryTest. script17
PostgreSQLQueryTest. script18
PostgreSQLQueryTest. script19
PostgreSQLQueryTest. script29
PostgreSQLQueryTest. script32

      then with 962badcea188f48da722cba396fb2478375065e7 only 16 tests still fail (see POLYGENE-137):

      PostgreSQLComplexQueryTest. script03
PostgreSQLComplexQueryTest. script05
PostgreSQLComplexQueryTest. script06
PostgreSQLComplexQueryTest. script07
PostgreSQLComplexQueryTest. script08
PostgreSQLComplexQueryTest. script09
PostgreSQLComplexQueryTest. script10
PostgreSQLComplexQueryTest. script11
PostgreSQLEntityFinderTest. script03
PostgreSQLEntityFinderTest. script18
PostgreSQLEntityFinderTest. script19
PostgreSQLQueryTest. script03
PostgreSQLQueryTest. script17
PostgreSQLQueryTest. script18
PostgreSQLQueryTest. script19
PostgreSQLQueryTest. script29

      then with 612f952a338ef93e305b90321de04b5ccc9c7930 only 9 tests still fail:

      PostgreSQLComplexQueryTest. script03
PostgreSQLComplexQueryTest. script05
PostgreSQLComplexQueryTest. script06
PostgreSQLComplexQueryTest. script07
PostgreSQLComplexQueryTest. script08
PostgreSQLComplexQueryTest. script09
PostgreSQLComplexQueryTest. script10
PostgreSQLComplexQueryTest. script11
PostgreSQLQueryTest. script29

      then def7765f4a21a8ead434a7599c75f6bffd2c165e made ALL tests fail again

      then f21cc656a72b6fb5fdca112b05133d7e63455a3d got us back to the 9 failing tests above

      then 103c59cbeb2907d0b3a132a1aa852e2e1b8585ae made a 10th test fail:

      PostgreSQLComplexQueryTest. script03
PostgreSQLComplexQueryTest. script05
PostgreSQLComplexQueryTest. script06
PostgreSQLComplexQueryTest. script07
PostgreSQLComplexQueryTest. script08
PostgreSQLComplexQueryTest. script09
PostgreSQLComplexQueryTest. script10
PostgreSQLComplexQueryTest. script11
PostgreSQLQueryTest. script29
PostgreSQLQueryTest. script34

      That last list is what actually fails on the head of develop.

      Indexing SQL extension tests need a running PostgreSQL instance properly set up. That makes asserting that changes don't break it difficult. We really need a test harness for required external services, see POLYGENE-221

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. POLYGENE-45 Investigate all @Ignore on tests.

          • Major - Major loss of function.
          • Closed
          is superceded by

          Improvement - An improvement or enhancement to an existing feature or task. POLYGENE-244 IQ2 - Indexing/Query Redesign

          • Major - Major loss of function.
          • Open

          Activity

            People

              niclas Niclas Hedhman
              eskatos Paul Merlin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: