[RATIS-1656] Leftover usage of ForkJoinPool.commonPool() in RaftServerImpl - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.0
Fix Version/s: 2.4.0, 3.0.0
Component/s: server
Labels:
None

Target Version/s:

2.4.0, 3.0.0

Description

RaftServerImpl#appendEntriesAsync is still using the common pool here:

https://github.com/apache/ratis/blob/3db8f9eac82efedd51322a0d213300c9a0940bb6/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L1416-L1417

    return JavaUtils.allOf(futures).whenCompleteAsync(
        (r, t) -> followerState.ifPresent(fs -> fs.updateLastRpcTime(FollowerState.UpdateType.APPEND_COMPLETE))

I think it should be executed directly, since it's already executing on serverExecutor.

Attachments

Issue Links

fixes

RATIS-530 Avoid using common fork join pool

Resolved

is related to

RATIS-1503 Avoid using ForkJoinPool.commonPool() in RaftServerProxy/Impl

Resolved

relates to

RATIS-1792 Replace parallelStream usage in PeerProxyMap

Resolved

links to

GitHub Pull Request #702

Activity

People

Assignee:: Attila Doroszlai

Reporter:: Attila Doroszlai

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 03/Aug/22 11:55

Updated:: 24/Feb/23 18:08

Resolved:: 07/Aug/22 06:28

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 40m