Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-979 Ratis streaming
  3. RATIS-1921

Shared worker group in WorkerGroupGetter should be closed

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0
    • Netty
    • None

    Description

      When benchmarking Ozone streaming pipeline using `ozone freon ockg`, the benchmark would not end although all the keys have been written. 

      Using Arthas, found that non-daemon threads like "NettyClientStreamRpc-workerGroup–thread1" are still running even after the benchmark has finished. 

      It seems that when hdds.ratis.raft.netty.dataStream.client.worker-group.share is set to true, it will create a worker group that will be shared. However, this worker group will never be closed causing the JVM shutdown hook to never be triggered. The benchmark was able to work normally if the share configuration is disabled.

      Need to find a way to shutdown the worker group gracefully without losing the shared worker group benefit.

      Attachments

        1. 955_review.patch
          6 kB
          Tsz-wo Sze

        Issue Links

          Activity

            People

              ivanandika Ivan Andika
              ivanandika Ivan Andika
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 20m
                  3h 20m