Uploaded image for project: 'S2Graph'
  1. S2Graph
  2. S2GRAPH-63

Condition on partition strong edges and weak edges on mutateEdges is wrong.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Done
    • Major
    • Resolution: Done
    • None
    • 0.1.0
    • None

    Description

      Storage#mutateEdges use following condition to separate strong edges and weak edges.

       val (strongEdges, weakEdges) =
            (edges.partition(e => e.label.consistencyLevel == "strong" || e.op == GraphUtil.operations("insertBulk")))
      

      I think current condition is wrong. the condition should be following.

       val (strongEdges, weakEdges) =
            (edges.partition(e => e.label.consistencyLevel == "strong" && e.op != GraphUtil.operations("insertBulk")
      

      Because of above bug, insertBulk is not working as intended(not lookup snapshotEdge and just build and fire RPCs).

      Attachments

        Issue Links

          Activity

            People

              steamshon Do Yung Yoon
              steamshon Do Yung Yoon
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Remaining Estimate - 24h
                  24h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified