Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-374

maven-scm-providers-git is missing some testdata

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1
    • 1.1
    • None
    • None
    • linux fedora-8, git-1.5.3.3., git-1.5.4
    • Patch

    Description

      It seems that something has gone missing by moving the maven-scm-providers-git plugin from git to SVN.
      I checked out the SVN version and compared it to my git repo.

      It seems that the test/resource/git/ ... /*.log files have been ignored.
      This files contain the testdata for testing the various commandline output consumers for the git executable.

      The appending patch does contain all missing files plus a small change in the way the base command is constructed.

      Tests and TCK successfully passed.

      Attachments

        1. maven-scm-providers-git-testdata.patch
          27 kB
          Mark Struberg
        2. git-diff-testlogs.patch
          33 kB
          Mark Struberg

        Activity

          jvanzyl Jason van Zyl added a comment -

          The tests do not all pass:

          Tests in error:
          testEmptyLogConsumer(org.apache.maven.scm.provider.git.gitexe.command.remove.GitRemoveConsumerTest)

          Can you take a look at this?

          jvanzyl Jason van Zyl added a comment - The tests do not all pass: Tests in error: testEmptyLogConsumer(org.apache.maven.scm.provider.git.gitexe.command.remove.GitRemoveConsumerTest) Can you take a look at this?
          struberg Mark Struberg added a comment -

          humm, it's actually in the patch, but it is essentially an empty file with the name

          maven-scm-provider-gitexe/src/test/resources/git/remove/gitrm-empty.gitlog
          

          Either 'patch' did not create the file for you if it's empty or your 'svn add' skipped it silently.
          I'll disable this single test if there is any argument against empty files.

          struberg Mark Struberg added a comment - humm, it's actually in the patch, but it is essentially an empty file with the name maven-scm-provider-gitexe/src/test/resources/git/remove/gitrm-empty.gitlog Either 'patch' did not create the file for you if it's empty or your 'svn add' skipped it silently. I'll disable this single test if there is any argument against empty files.
          brett Brett Porter added a comment -

          I've applied the patch - thanks!

          However, I still got failures in commons and had to comment out the test in there. It looks like that test belongs in gitexe where these resource files were placed?

          brett Brett Porter added a comment - I've applied the patch - thanks! However, I still got failures in commons and had to comment out the test in there. It looks like that test belongs in gitexe where these resource files were placed?

          ping

          evenisse Emmanuel Venisse added a comment - ping

          All git diff test resources files are missing

          evenisse Emmanuel Venisse added a comment - All git diff test resources files are missing
          struberg Mark Struberg added a comment -

          > It looks like that test belongs in gitexe where these resource files were placed?
          Yes, most tests are in gitexe, only a few in git-commons.

          For the diff-consumer tests in git-commons: I'm currently on vacation, but I'll try to compare all of the current version from the SVN and my git repo in the afternoon - thanks for the patience.

          struberg Mark Struberg added a comment - > It looks like that test belongs in gitexe where these resource files were placed? Yes, most tests are in gitexe, only a few in git-commons. For the diff-consumer tests in git-commons: I'm currently on vacation, but I'll try to compare all of the current version from the SVN and my git repo in the afternoon - thanks for the patience.
          struberg Mark Struberg added a comment -

          Hi Emmanuel!

          Somehow my local .svn metainfo was broken, so after a completely new checkout I finally know what you are talking about.
          The git-diff-testlogs.patch contains the 3 missing files. But be prepared that looking at the patch may cause headache, because diffing a diff result is somewhat confusing...

          struberg Mark Struberg added a comment - Hi Emmanuel! Somehow my local .svn metainfo was broken, so after a completely new checkout I finally know what you are talking about. The git-diff-testlogs.patch contains the 3 missing files. But be prepared that looking at the patch may cause headache, because diffing a diff result is somewhat confusing...
          olamy Olivier Lamy added a comment -

          no news on that point.
          btw all tests pass currently in the git provider.
          IMHO we can close it or move it to 1.2.

          olamy Olivier Lamy added a comment - no news on that point. btw all tests pass currently in the git provider. IMHO we can close it or move it to 1.2.

          Brett mentioned that he disabled some tests, so that might be the reason they pass.

          dennisl@apache.org Dennis Lundberg added a comment - Brett mentioned that he disabled some tests, so that might be the reason they pass.
          olamy Olivier Lamy added a comment - - edited

          ok I will search .
          btw I have tested the git provider with the release plugin and all looks fine.
          Tests are in this git-hub repos : http://github.com/olamy/
          One repo with a simple project, one with a project with modules.
          I have tested on the following os :

          • windows (with the windows cli).
          • cygwin cli.
          • linux (ubuntu).
          • mac (thanks to tcurdt for testing time).

          Then I have tested the update command implementation (see SCM-396) with continuum and it works fine too.

          olamy Olivier Lamy added a comment - - edited ok I will search . btw I have tested the git provider with the release plugin and all looks fine. Tests are in this git-hub repos : http://github.com/olamy/ One repo with a simple project, one with a project with modules. I have tested on the following os : windows (with the windows cli). cygwin cli. linux (ubuntu). mac (thanks to tcurdt for testing time). Then I have tested the update command implementation (see SCM-396 ) with continuum and it works fine too.
          olamy Olivier Lamy added a comment -

          ok here rev 653981

          olamy Olivier Lamy added a comment - ok here rev 653981
          olamy Olivier Lamy added a comment -

          fix in rev 684588

          olamy Olivier Lamy added a comment - fix in rev 684588

          People

            olamy Olivier Lamy
            struberg Mark Struberg
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: