Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-981

Several integration tests are never run and fail if you do

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-M2
    • None
    • None

    Description

      The README.md states

      Run all the tests with `mvn -Prun-its verify` to assure nothing else was accidentally broken.

      The Github actions reuses for the CI build

      apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2

      which does the same

      ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures" -P run-its verify

      https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167
      https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93

      The snag is that this profile does not exist in this project.

      I asked this and was told to use the `tck-git` profile
      https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768

      I found that there is also a `tck-svn` profile and a `tck` profile.

      When I run `mvn clean verify -Ptck` there are several tests that fail and are apparently never run by anyone.

       

      Proposal: 

      • Create a profile run-its that simply activates the appropriate tck profiles.
      • Fix the failing tests.

       

      Attachments

        Issue Links

          Activity

            People

              michael-o Michael Osipov
              nielsbasjes Niels Basjes
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: