Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10207

NodeTypesEntryHandler does not consider CND files outside of META-INF/vault/nodetypes.cnd

    XMLWordPrintableJSON

Details

    Description

      Namespace and node type definitions can not only be given in /META-INF/vault/nodetypes.cnd but also in other cnd files inside the package (compare with Package property cndPattern, http://jackrabbit.apache.org/filevault/properties.html).
      Currently only those in /META-INF/vault/nodetypes.cnd are correctly extracted though: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/handlers/NodeTypesEntryHandler.java#L32 because the pattern being registered in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java#L425 does not start with the jcr_root prefix.

      CND patterns in package are matched against absolute repository paths while patterns for AbstractRegexEntryHandler are matched against the ZIP package file path.

      Attachments

        Issue Links

          Activity

            People

              kwin Konrad Windszus
              kwin Konrad Windszus
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: