Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6638

Vault Package Builder should not allow SHA1, MD5 digest algorithm

    XMLWordPrintableJSON

Details

    Description

      The VaultDistributionPackageBuilderFactory [0] proposes the MD5, MD2 and SHA-1 algorithms, for which collisions could realistically be forged.

      SCD makes use of those algorithm for error detection (like a CRC) and not for security. Despite that, we should deprecate the use of those algorithms IMO.

      I propose to remove the three algorithms form the list of proposals, and throw and exception if a non supported algorithm is used. The component end up not being activated unless the configuration is corrected.

      [0] https://github.com/apache/sling/blob/trunk/contrib/extensions/distribution/core/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L191-L193

      Attachments

        Activity

          People

            marett Timothee Maret
            marett Timothee Maret
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: