Uploaded image for project: 'ServiceMix'
  1. ServiceMix
  2. SM-384

In org.apache.servicemix.jbi.messaging.NormalizedMessageImpl, it appears that the getters and setters are innappropriately synchronized

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.1
    • 3.0-M1
    • servicemix-core
    • None

    Description

      It's possible that we do not need to synchronize the getters and setters of the NormalizedMessageImpl class. Removing these synchronizations should increase performance when manipulating messages. Whoever authored this class should be consulted as to the reasons behind doing this. Are we worried about multiple threads accessing the same normalized message? The only time I see this happening is if a component spawns multiple threads working on the same NormalizedMessage, but even in this case we could use a wrapper class that synchronizes the necessary methods. Perhaps there is something in the core library of servicemix that needs these synchronized?

      Attachments

        Activity

          People

            gnodet Guillaume Nodet
            jpuro Jeff Puro
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: