Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-17314

SolrClient implementations should not mutate request objects

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • main (10.0), 9.6
    • None
    • None

    Description

      Currently, our "load balancing" SolrClient implementations mutate the SolrRequest instances they're operating on, changing the "basePath" as a way to dictate which Solr node the request is ultimately routed to.

      This is effective for the LB client's purposes, but it can cause problems especially in SolrJ code that reuses SolrRequest objects for multiple requests. (This is pretty common - Solr itself and its test code does this frequently).

      This ticket aims to cover restructuring our "LB" client code so that it no longer quietly mutates the objects provided by callers.

      Attachments

        Issue Links

          Activity

            People

              gerlowskija Jason Gerlowski
              gerlowskija Jason Gerlowski
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: