Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2762

FSTLookup returns one less suggestion than it should when onlyMorePopular=true

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.3, 3.4
    • 3.5
    • spellchecker
    • None

    Description

      I'm using the Suggester. When I switched from TSTLookup to FSTLookup, I noticed that it returned one fewer suggestion than what I asked for. I have spellcheck.onlyMorePopular=true; when I set it to false, I see the correct count. Another aspect of the bug is that this off-by-one bug only seems to occur when my suggestion has an exact match.

      Attachments

        1. SOLR-2762.patch
          6 kB
          Dawid Weiss
        2. SOLR-2762.patch
          6 kB
          Dawid Weiss
        3. SOLR-2762.patch
          4 kB
          Dawid Weiss
        4. SOLR-2762_FSTLookup_off_by_one.patch
          2 kB
          David Smiley
        5. SOLR-2762_FSTLookup_off_by_one.patch
          2 kB
          David Smiley

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-2761 FSTLookup should use long-tail like discretization instead of proportional (linear)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              dweiss Dawid Weiss
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: