Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3913

SimplePostTool optimize does a redundant commit

    XMLWordPrintableJSON

Details

    Description

      At the end of SimplePostTool.execute() there is:

          if (commit)   commit();
          if (optimize) optimize();
      

      Each of these calls involves a separate request to Solr. The thing is, an optimize internally commits, and so the logic should forgo committing is optimize is true.

      And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it should be around 8kb (8192) bytes which is the same value as BufferedInputStream's default.

      Attachments

        Issue Links

          Activity

            People

              epugh Eric Pugh
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m