Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4189

Fix hanging threads on FreeBSD in JettySolrRunner by making connector configureable through sysprop

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.1, 6.0
    • Tests
    • None

    Description

      Currently on FreeBSD we run no Solr tests, because the SelectChannelConnector, recently used for Solr's JettySolrRunner seems to linger threads, which may be caused by the blackhole or more likely a JVM bug.

      This patch allows to configure the connector for the testMode Jetty in embedded Solr through a sysprop:

      ant test -Dtests.jettyConnector=Socket
      ant test -Dtests.jettyConnector=SelectChannel
      

      The default is SelectChannel. On FreeBSD Jenkins I would pass this as property to ANT through Jenkins config (where currently the tests are disabled). On Maven this should also be possible (Steven?).

      The patch also binds the test-mode jetty to 127.0.0.1 to prevent windows firewall from popping up all the time, because Solr binds to internet. For tests, the emebedded Jetty should never run on all interfaces (0.0.0.0).

      Attachments

        1. SOLR-4189.patch
          2 kB
          Uwe Schindler
        2. SOLR-4189.patch
          3 kB
          Steven Rowe
        3. SOLR-4189.patch
          4 kB
          Uwe Schindler

        Activity

          People

            uschindler Uwe Schindler
            uschindler Uwe Schindler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: