Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4735

Improve Solr metrics reporting

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.4, 7.0
    • metrics
    • None

    Description

      Following on from a discussion on the mailing list:
      http://search-lucene.com/m/IO0EI1qdyJF1/codahale&subj=Solr+metrics+in+Codahale+metrics+and+Graphite+

      It would be good to make Solr play more nicely with existing devops monitoring systems, such as Graphite or Ganglia. Stats monitoring at the moment is poll-only, either via JMX or through the admin stats page. I'd like to refactor things a bit to make this more pluggable.

      This patch is a start. It adds a new interface, InstrumentedBean, which extends SolrInfoMBean to return a [Metrics MetricRegistry, and a couple of MetricReporters (which basically just duplicate the JMX and admin page reporting that's there at the moment, but which should be more extensible). The patch includes a change to RequestHandlerBase showing how this could work. The idea would be to eventually replace the getStatistics() call on SolrInfoMBean with this instead.

      The next step would be to allow more MetricReporters to be defined in solrconfig.xml. The Metrics library comes with ganglia and graphite reporting modules, and we can add contrib plugins for both of those.

      There's some more general cleanup that could be done around SolrInfoMBean (we've got two plugin handlers at /mbeans and /plugins that basically do the same thing, and the beans themselves have some weirdly inconsistent data on them - getVersion() returns different things for different impls, and getSource() seems pretty useless), but maybe that's for another issue.

      Attachments

        1. SOLR-4735.patch
          47 kB
          Alan Woodward
        2. SOLR-4735.patch
          52 kB
          Alan Woodward
        3. SOLR-4735.patch
          53 kB
          Alan Woodward
        4. SOLR-4735.patch
          55 kB
          Christine Poerschke
        5. screenshot-2.png
          425 kB
          Andrzej Bialecki
        6. SOLR-4735.patch
          181 kB
          Andrzej Bialecki
        7. SOLR-4735.patch
          222 kB
          Andrzej Bialecki

        Issue Links

          contains

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9731 Add jvm-wide JMX statistics for Solr

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-6586 JmxMonitoredMap#getAttribute is not very efficient.

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-6788 Expose Solr version via MBean

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9462 Report aggregated cache stats for all cores on a Solr node

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-8785 Use Metrics library for core metrics

          • Major - Major loss of function.
          • Resolved
          is required by

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9854 Collect metrics for index merges and index store IO

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9856 Collect metrics for shard replication and tlog replay on replicas

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9857 Collect aggregated metrics from replicas in shard leader

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9858 Collect aggregated metrics from nodes and shard leaders in overseer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-5095 SolrCore.infoRegistry needs overhauled with some form of "namespacing"

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. SOLR-15023 Timeout Issue with Solr Metrics API

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SOLR-9805 Use metrics-jvm library to instrument jvm internals

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-6757 SolrInfoMBean should be an abstract class rather than an interface.

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-9788 Use instrumented jetty classes

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #119

          Web Link GitHub Pull Request #120

          Web Link GitHub Pull Request #120

          Activity

            People

              ab Andrzej Bialecki
              romseygeek Alan Woodward
              Votes:
              8 Vote for this issue
              Watchers:
              26 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m