Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5286

Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 4.5, 6.0
    • Build, Schema and Analysis
    • None

    Description

      The analysis-extras contrib no longer has Morfologik, Stempel, or Smartcn analysis factories - these were moved as part of LUCENE-4044 - but jars for these remain in the build.xml and ivy.xml configuration files, and are mentioned in the README.txt.

      Attachments

        1. SOLR-5286-revert.patch
          4 kB
          Steven Rowe
        2. SOLR-5286.patch
          5 kB
          Steven Rowe

        Activity

          sarowe Steven Rowe added a comment -

          Patch fixing ivy.xml, build.xml, pom.xml.template, and README.txt.

          Committing shortly.

          sarowe Steven Rowe added a comment - Patch fixing ivy.xml, build.xml, pom.xml.template, and README.txt. Committing shortly.

          Commit 1527168 from steve_rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1527168 ]

          SOLR-5286: Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration

          jira-bot ASF subversion and git services added a comment - Commit 1527168 from steve_rowe in branch 'dev/trunk' [ https://svn.apache.org/r1527168 ] SOLR-5286 : Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration

          Commit 1527169 from steve_rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1527169 ]

          SOLR-5286: Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration (merged trunk r1527168)

          jira-bot ASF subversion and git services added a comment - Commit 1527169 from steve_rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1527169 ] SOLR-5286 : Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration (merged trunk r1527168)

          Commit 1527170 from steve_rowe in branch 'dev/branches/lucene_solr_4_5'
          [ https://svn.apache.org/r1527170 ]

          SOLR-5286: Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration (merged trunk r1527168)

          jira-bot ASF subversion and git services added a comment - Commit 1527170 from steve_rowe in branch 'dev/branches/lucene_solr_4_5' [ https://svn.apache.org/r1527170 ] SOLR-5286 : Remove vestigial Chinese and Polish analysis jars from the analysis-extras contrib configuration (merged trunk r1527168)
          sarowe Steven Rowe added a comment -

          Committed to trunk, branch_4x, and lucene_solr_4_5 branch.

          sarowe Steven Rowe added a comment - Committed to trunk, branch_4x, and lucene_solr_4_5 branch.
          sarowe Steven Rowe added a comment -

          AFAICT, these "vestigial" Chinese and Polish analysis jars are there solely to populate the Solr distribution, rather than as dependencies of code in the analysis-extras contrib.

          Reopening to revert these changes.

          sarowe Steven Rowe added a comment - AFAICT, these "vestigial" Chinese and Polish analysis jars are there solely to populate the Solr distribution, rather than as dependencies of code in the analysis-extras contrib. Reopening to revert these changes.
          sarowe Steven Rowe added a comment -

          Patch reverting the changes done here.

          I didn't revert the compile step building the "depended-on" Lucene modules, since they aren't needed for compilation.

          I added comments in build.xml and ivy.xml telling people not to do this again.

          I reworded the README.txt to explain dependencies per feature instead of lumping them all together.

          I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib.

          Committing shortly.

          sarowe Steven Rowe added a comment - Patch reverting the changes done here. I didn't revert the compile step building the "depended-on" Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib. Committing shortly.

          Commit 1527175 from steve_rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1527175 ]

          SOLR-5286: revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib.

          jira-bot ASF subversion and git services added a comment - Commit 1527175 from steve_rowe in branch 'dev/trunk' [ https://svn.apache.org/r1527175 ] SOLR-5286 : revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib.

          Commit 1527176 from steve_rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1527176 ]

          SOLR-5286: revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib. (merged trunk r1527175)

          jira-bot ASF subversion and git services added a comment - Commit 1527176 from steve_rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1527176 ] SOLR-5286 : revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib. (merged trunk r1527175)

          Commit 1527177 from steve_rowe in branch 'dev/branches/lucene_solr_4_5'
          [ https://svn.apache.org/r1527177 ]

          SOLR-5286: revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib. (merged trunk r1527175)

          jira-bot ASF subversion and git services added a comment - Commit 1527177 from steve_rowe in branch 'dev/branches/lucene_solr_4_5' [ https://svn.apache.org/r1527177 ] SOLR-5286 : revert changes committed on this issue; the internal and 3rd party dependencies in the analysis-extras contrib are used to put these jars into the Solr distribution. I didn't revert the compile step building the depended-on Lucene modules, since they aren't needed for compilation. I added comments in build.xml and ivy.xml telling people not to do this again. I reworded the README.txt to explain dependencies per feature instead of lumping them all together. I did not revert the pom.xml.template changes, since the dependencies are not required for compilation or runtime use of the code in the analysis-extras contrib. (merged trunk r1527175)
          sarowe Steven Rowe added a comment -

          Committed the revert patch to trunk, branch_4x and lucene_solr_4_5 branch.

          sarowe Steven Rowe added a comment - Committed the revert patch to trunk, branch_4x and lucene_solr_4_5 branch.
          jpountz Adrien Grand added a comment -

          4.5 release -> bulk close

          jpountz Adrien Grand added a comment - 4.5 release -> bulk close

          People

            sarowe Steven Rowe
            sarowe Steven Rowe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: