Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-18088

ChiSqSelector FPR PR cleanups

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.1.0
    • ML
    • None

    Description

      This should be in 2.1 since it modifies new APIs (in 2.1). Pushing this to 2.2 would prevent us from improving the APIs.

      There are several cleanups I'd like to make as a follow-up to the PRs from SPARK-17017:

      • Rename selectorType values to match corresponding Params
      • Add Since tags where missing
      • a few minor cleanups

      Attachments

        Issue Links

          is depended upon by

          New Feature - A new feature of the product, which has yet to be developed. SPARK-17645 Add feature selector methods based on: False Discovery Rate (FDR) and Family Wise Error rate (FWE)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          New Feature - A new feature of the product, which has yet to be developed. SPARK-17017 Add a chiSquare Selector based on False Positive Rate (FPR) test

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Pull request #15647 [Github] Pull Request #15647 (jkbradley)

          Activity

            People

              josephkb Joseph K. Bradley
              josephkb Joseph K. Bradley
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: