Uploaded image for project: 'SystemDS'
  1. SystemDS
  2. SYSTEMDS-1449

Potential bug in compare method

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • SystemML 0.14
    • None
    • None

    Description

      Hi

      In recent github mirror, I've found the following issue.

      Path: src/main/java/org/apache/sysml/hops/QuaternaryOp.java

      1566 
1567                 //compare basic inputs and weights (always existing)
1568                 boolean ret = (_op == that2._op
1569                                 && getInput().size() == getInput().size()
1570                                 && getInput().get(0) == that2.getInput().get(0)
1571                                 && getInput().get(1) == that2.getInput().get(1)
1572                                 && getInput().get(2) == that2.getInput().get(2) );
1573

      Line 1569 should be like this? Or, removing the line is just OK?

      1569                                 && getInput().size() == that2.getInput().size()

      Attachments

        Activity

          People

            mboehm7 Matthias Boehm
            lifove JC
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: