Uploaded image for project: 'Apache Taverna'
  1. Apache Taverna
  2. TAVERNA-976

Consistent ASF file headers in Taverna Mobile

    XMLWordPrintableJSON

Details

    • Task
    • Status: Done
    • Major
    • Resolution: Done
    • None
    • None
    • Taverna Mobile
    • None

    Description

      The ASF file headers in taverna-mobile are a bit inconsistent to general practice, e.g.

      https://github.com/apache/incubator-taverna-mobile/blob/master/app/src/main/java/org/apache/taverna/mobile/activities/LoginActivity.java

      /*
      * Apache Taverna Mobile
      * Copyright 2015 The Apache Software Foundation
      * This product includes software developed at
      * The Apache Software Foundation (http://www.apache.org/).
      * Licensed to the Apache Software Foundation (ASF) under one
      * or more contributor license agreements. See the NOTICE file
      * distributed with this work for additional information
      * regarding copyright ownership. The ASF licenses this file
      * to you under the Apache License, Version 2.0 (the
      * "License"); you may not use this file except in compliance
      * with the License. You may obtain a copy of the License at
      *
      * http://www.apache.org/licenses/LICENSE-2.0
      *
      * Unless required by applicable law or agreed to in writing,
      * software distributed under the License is distributed on an
      * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
      * KIND, either express or implied. See the License for the
      * specific language governing permissions and limitations
      * under the License.
      */
      

      The first lines belong only in the NOTICE, and should not be replicated in every file. Thus I think we should have a consistent file header as:

      /*
       * Licensed to the Apache Software Foundation (ASF) under one
       * or more contributor license agreements.  See the NOTICE file
       * distributed with this work for additional information
       * regarding copyright ownership.  The ASF licenses this file
       * to you under the Apache License, Version 2.0 (the
       * "License"); you may not use this file except in compliance
       * with the License.  You may obtain a copy of the License at
       * 
       *   http://www.apache.org/licenses/LICENSE-2.0
       * 
       * Unless required by applicable law or agreed to in writing,
       * software distributed under the License is distributed on an
       * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       * KIND, either express or implied.  See the License for the
       * specific language governing permissions and limitations
       * under the License.
       */
      package org.apache.taverna.mobile.data;
      

      This task involves also checking other files (e.g. XML) that they have the correct headers (which would need a different comment style – see also https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980

      Attachments

        Activity

          People

            Unassigned Unassigned
            stain Stian Soiland-Reyes
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: