Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1921

Make Haskell work with new GHC

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Invalid
    • None
    • None
    • Haskell - Compiler
    • None
    • Patch Available

    Description

      The Thrift Haskell compiler is generating code that's not working with the current version of Haskell's GHC compiler, and the current Haskell library.

      The fix is simple:

      • Remove the import import Thrift.Types () because this moduled does not exist.
      • Map Thrift type string to Haskell's String (instead of Text) - that's what the Haskell Thrift library accepts.
      • Don't map "include" to "import qualified" (symbols are expected to be in the global scope).

      Attachments

        1. thrift-hs-fix.patch
          2 kB
          Rodrigo Setti

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-1927 Add Haskell required Hashable instances

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-1927 Add Haskell required Hashable instances

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              rodrigosetti Rodrigo Setti
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: