Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2744 Vagrantfile for Centos 6.5
  3. THRIFT-2746

Compiler C++98 conformance

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.2
    • 0.9.2
    • C++ - Compiler, Haskell - Compiler
    • None

    • all

    • Patch Available

    Description

      This is the piece of the CentOS 6.5 patch that cleans up the compiler build errors due to C + + 11 code in the Haskell and C++ generators.

      C + + 11 elements replaced:

      • Ranged for loops: for ( auto x : container )
      • Type deduction: auto
      • NULL assignment to boost::shared_ptr: replaced with .reset()
      • Constructor initialization of boost::shared_ptr with 0: replaced with ""
      • Nondeterministic compiler dependent for loop scoping: changed iterators to inner scope

      Attachments

        1. readme_fix.patch
          0.7 kB
          Konrad Grochowski
        2. 0001-Thrift-Compiler-fixes-to-keep-code-C-98.patch
          20 kB
          Randy Abernethy

        Issue Links

          is part of

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-2744 Vagrantfile for Centos 6.5

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-2711 Travis reports false possitive while building with mingw

          • Major - Major loss of function.
          • Closed

          Activity

            People

              codesf Randy Abernethy
              codesf Randy Abernethy
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: